DX improvements for the unit tests #9805
Open
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhousel
added a commit
to facebook/Rapid
that referenced
this pull request
Aug 14, 2023
(closes #1013, re: openstreetmap/iD#9805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing
@types/chaiand declaringexpectas a global means that IDEs like VS Code can provide auto-complete suggestions as you type, which makes it much easier to write tests for people who aren't familiar with chailikewise, declaring the type of
window.iDmeans that IDEs can show suggestions and allow you to use a keyboard shortcut like F12 to jump to the definition of any function. I think this would pretty helpful for occasional contributors like myself